> On Aug. 6, 2012, 5:33 a.m., Juhani Connolly wrote: > > Since Hari isn't too familiar with scribe he asked me to look at it. > > > > Having done so, I think it seems fine. I have also verified it works on our > > local cluster. > > > > The code generation profile however does not work(the pom for maven-thrift > > can't be located). I'm also unsure of attaching the apache license to the > > pregenerated sources is ok, and have sent a query regarding that to the dev > > list. > > > > Sorry for the hold up, and hopefully everything should be ok and I can > > commit it asap. > > Denny Ye wrote: > hi Juhani, Thanks for your response. IMO, Thrift is Apache 2.0 License, > also generated code from Thrift might be have same license
yes, thrift is, I was thinking more of the scribe end of it: https://github.com/facebook/scribe/blob/master/if/scribe.thrift I guess that is also apache 2 licensed so it probably isn't a problem. I'm just going to sit on this so other people can get input and if there isn't a problem with it I'll go ahead and push it through - Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6089/#review9875 ----------------------------------------------------------- On Aug. 6, 2012, 7:53 a.m., Denny Ye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6089/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 7:53 a.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > There may someone like me that want to replace central Scribe with Flume to > adopt existing ingest system, using smooth changes for application user. > Here is the ScribeSource put into legacy folder without deserializing. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1382. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1382 > > > Diffs > ----- > > trunk/flume-ng-dist/pom.xml 1364507 > trunk/flume-ng-legacy-sources/flume-scribe-source/pom.xml PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/LogEntry.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ResultCode.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > PRE-CREATION > > trunk/flume-ng-legacy-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java > PRE-CREATION > trunk/flume-ng-legacy-sources/pom.xml 1364507 > trunk/pom.xml 1364507 > > Diff: https://reviews.apache.org/r/6089/diff/ > > > Testing > ------- > > I already used ScribeSource into local environment and tested in past week. > It can use the existing local Scribe interface > > > Thanks, > > Denny Ye > >
