> On Aug. 15, 2012, 4:01 a.m., Juhani Connolly wrote: > > Ok, I had a look over, and tested the new code and it seems fine. Other > > additions look good too > > > > It would have been nice to have the documentation as part of the review > > too, but this issue has been in review long enough, so I might open another > > ticket later to review the documentation and add more information on usage.
Thanks Juhani, I also consider that it need another case to review document. Need your advice in usage of ScribeSource - Denny ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6089/#review10316 ----------------------------------------------------------- On Aug. 14, 2012, 6:53 a.m., Denny Ye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6089/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 6:53 a.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > There may someone like me that want to replace central Scribe with Flume to > adopt existing ingest system, using smooth changes for application user. > Here is the ScribeSource put into legacy folder without deserializing. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1382. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1382 > > > Diffs > ----- > > trunk/flume-ng-dist/pom.xml 1370121 > trunk/flume-ng-sources/flume-scribe-source/pom.xml PRE-CREATION > > trunk/flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/LogEntry.java > PRE-CREATION > > trunk/flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ResultCode.java > PRE-CREATION > > trunk/flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > PRE-CREATION > > trunk/flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java > PRE-CREATION > trunk/flume-ng-sources/pom.xml PRE-CREATION > trunk/pom.xml 1370121 > > Diff: https://reviews.apache.org/r/6089/diff/ > > > Testing > ------- > > I already used ScribeSource into local environment and tested in past week. > It can use the existing local Scribe interface > > > Thanks, > > Denny Ye > >
