----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5467/#review13140 -----------------------------------------------------------
Ship it! Ship It! - Alexander Alten-Lorenz On June 21, 2012, 12:55 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5467/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 12:55 a.m.) > > > Review request for Flume. > > > Description > ------- > > * Checks to make sure the supervisor is still running, before supervising > more components > * Make sure shutdown of monitor threads happen before the component's stop() > is called. > > > This addresses bug FLUME-1296. > https://issues.apache.org/jira/browse/FLUME-1296 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java > 2935e64 > > Diff: https://reviews.apache.org/r/5467/diff/ > > > Testing > ------- > > All current unit tests pass. Ran an agent with a dummy sink that never starts > but checks thread interrupt every 5 seconds - works fine. > > > Thanks, > > Hari Shreedharan > >
