Re: Review Request: FLUME-1296: Lifecycle supervisor should check if the monitor service is still running before supervising and also make sure shutdown of monitor service happens before component is stopped.

[Hari Shreedharan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5467/
-----------------------------------------------------------

(Updated Dec. 10, 2012, 7:21 p.m.)


Review request for Flume.


Description
-------

* Checks to make sure the supervisor is still running, before supervising more 
components
* Make sure shutdown of monitor threads happen before the component's stop() is 
called.


This addresses bug FLUME-1296.
    https://issues.apache.org/jira/browse/FLUME-1296


Diffs (updated)
-----

  
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 
78eda05 

Diff: https://reviews.apache.org/r/5467/diff/


Testing
-------

All current unit tests pass. Ran an agent with a dummy sink that never starts 
but checks thread interrupt every 5 seconds - works fine.


Thanks,

Hari Shreedharan