----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7062/#review14112 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java <https://reviews.apache.org/r/7062/#comment30180> Nit: The error messages are missing some spaces. flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java <https://reviews.apache.org/r/7062/#comment30178> Wish: Can we add a error message to this line as well? - Brock Noland On Sept. 12, 2012, 9:40 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7062/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 9:40 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add checks to make sure they are positive, if not, reset to default. > > > This addresses bug FLUME-1571. > https://issues.apache.org/jira/browse/FLUME-1571 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 66f7536 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 8baf8fe > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > c72e97c > flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java > e070864 > > Diff: https://reviews.apache.org/r/7062/diff/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari Shreedharan > >
