----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7062/#review14276 -----------------------------------------------------------
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/7062/#comment30409> I think we should specify this is transaction capacity. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/7062/#comment30410> This isn't the checkpoint write time out as the message indicates, it's the checkpoint interval. - Brock Noland On Dec. 10, 2012, 7:07 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7062/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 7:07 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add checks to make sure they are positive, if not, reset to default. > > > This addresses bug FLUME-1571. > https://issues.apache.org/jira/browse/FLUME-1571 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 64a1350 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 87a0a3f > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > 87a1305 > flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java > e1a61c2 > > Diff: https://reviews.apache.org/r/7062/diff/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari Shreedharan > >
