Hi,
Not too long ago all the messages in the git log started with the
corresponding jira. I found this habit very useful.
The how to contribute page asks to have a jira first for each change. I
guess with allowing pull requests we have to update the how to contribute
page as well (which only describes attaching patch and using review board).
I would like to ask committers to reestablish the habit of having a jira
for each commit and start the message with that jira.
If we would like to relax the have jira for each change (for pull requests)
then I would suggest putting the request id as the first thing in the
commit message.
instead of:
Author: Mike Percy <mpe...@apache.org>
Date: Wed Oct 12 19:32:13 2016 +0200
Remove test dependencies from binary release artifact
This patch removes some test-specific dependencies from the binary
release artifact. These were introduced by the new
flume-shared-kafka-test module that is intended for sharing test code.
Please see the new comment in bin.xml for more information.
Reviewers: Bessenyei Balázs Donát
Closes #70
I would suggest:
Author: Mike Percy <mpe...@apache.org>
Date: Wed Oct 12 19:32:13 2016 +0200
FLUME-XXXX Remove test dependencies from binary release artifact
This patch removes some test-specific dependencies from the binary
release artifact. These were introduced by the new
flume-shared-kafka-test module that is intended for sharing test code.
Please see the new comment in bin.xml for more information.
Reviewers: Bessenyei Balázs Donát
Closes #70
or the relaxed version if it is really needed to drop the jira requirement:
Author: Mike Percy <mpe...@apache.org>
Date: Wed Oct 12 19:32:13 2016 +0200
FLUME-PR70 Remove test dependencies from binary release artifact
This patch removes some test-specific dependencies from the binary
release artifact. These were introduced by the new
flume-shared-kafka-test module that is intended for sharing test code.
Please see the new comment in bin.xml for more information.
Reviewers: Bessenyei Balázs Donát
Closes #70
Cheers,
Attila
