Hi Mike, I'm a big fan of having the site in scm so I guess I can volunteer after Donat finishes that movement. I have no strong opinion on whether we should have a jira or not (thus the proposal of FLUME-PR70). I just "I found this habit very useful". I have tooling which depends on the commit titles are unique with high probability. Most likely these tools can be upgraded with some extra effort. Maybe having jira for each change is an overkill for small changes. What do you think what can be considered as a small change? eg the ones for which the "how to contribute" guide doesn't require review board?
Cheers, Attila On Fri, Oct 21, 2016 at 12:54 PM, Mike Percy <[email protected]> wrote: > > Hi Attila, > Thanks for raising this concern of yours. Please see inline. > > On Fri, Oct 21, 2016 at 12:17 PM, Attila Simon <[email protected]> wrote: > > > The how to contribute page asks to have a jira first for each change. I > > guess with allowing pull requests we have to update the how to contribute > > page as well (which only describes attaching patch and using review board). > > > > Yes, it appeared that we had consensus for allowing PR on a couple separate > dev@ threads a while back [1], [2]. > > The Flume contributor docs are currently a bit stale. I have recently > updated the How to Release cwiki page but if you want to volunteer to > update some of the other docs that would be very welcome! Please let me > know if you want to help and I can give you cwiki edit access if you send > me your account id. Side note: Donat has recently proposed moving those > docs from cwiki to the Git repo which I think would be a big improvement. > > I would like to ask committers to reestablish the habit of having a jira > > for each commit and start the message with that jira. > > > > Forcing people to file a JIRA when they are already doing a PR feels like > pointless extra paperwork to me. There is certainly a place for JIRA in a > software project, but I think that is to track unfixed bugs, ongoing tasks > / projects, etc. > > > > If we would like to relax the have jira for each change (for pull requests) > > then I would suggest putting the request id as the first thing in the > > commit message. > > > > Why? > > If you click on this: > https://github.com/apache/flume/commit/87d4c2c13862144eb578b211bcf800b2206834ff > > You will see that the text "Closes #70" creates a clickable hyperlink to > the PR. Is this not sufficient for tracking purposes? > > Mike > > [1] https://s.apache.org/k31f > [2] https://s.apache.org/Skm2
