----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51802/#review153276 -----------------------------------------------------------
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java (line 127) <https://reviews.apache.org/r/51802/#comment223529> Non breaking change as the password can still be specified as "". (eg by creating an empty password file with touch and specifying that in flume conf) flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java (lines 87 - 102) <https://reviews.apache.org/r/51802/#comment222556> Could you please use an Enum instead of boolean flags? - Attila Simon On Sept. 12, 2016, 1:08 p.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51802/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 1:08 p.m.) > > > Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila > Simon. > > > Bugs: FLUME-2976 > https://issues.apache.org/jira/browse/FLUME-2976 > > > Repository: flume-git > > > Description > ------- > > If no `userName` and `passwordFile` is set for the JMS source it sets the > password to `Optional("")`. This leads to an exception in the weblogic jndi > context implementation when trying to connect to a weblogic jms server. > > > Diffs > ----- > > > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java > 7631827 > > flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java > 53cc09a > > Diff: https://reviews.apache.org/r/51802/diff/ > > > Testing > ------- > > - `flume-ng-sources/flume-jms-source` tests pass > - `TestIntegrationActiveMQ` is now a parameterized test to test with and > without authentication. > > > Thanks, > > Denes Arvay > >
