----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51802/ -----------------------------------------------------------
(Updated Jan. 2, 2017, 3:19 p.m.) Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon. Changes ------- Introduced `TestMode` enum. Bugs: FLUME-2976 https://issues.apache.org/jira/browse/FLUME-2976 Repository: flume-git Description ------- If no `userName` and `passwordFile` is set for the JMS source it sets the password to `Optional("")`. This leads to an exception in the weblogic jndi context implementation when trying to connect to a weblogic jms server. Diffs (updated) ----- flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java 7631827 flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java 53cc09a Diff: https://reviews.apache.org/r/51802/diff/ Testing ------- - `flume-ng-sources/flume-jms-source` tests pass - `TestIntegrationActiveMQ` is now a parameterized test to test with and without authentication. Thanks, Denes Arvay