LGTM, +1.
However, I'd like to request a review on
https://github.com/apache/flume/commit/4fcf23d7eeecebcad39995bdb8dcfeb03453273b
, because I see no review references either in the commit message or the
Jira ticket.
Ideally, I'd like Ralph to approve this, as I believe it was him having
issues with the change at hand.


Donat


On Wed, Dec 19, 2018 at 9:28 PM Mike Percy <mpe...@apache.org> wrote:
>
> +1 on RC3
>
>  - Sigs and checksums match for source and binary artifacts
>  - Source artifact matches git tag
>  - LICENSE file looks good
>  - README looks good
>  - Source artifact builds and tests pass on Ubuntu bionic
>  - Binary artifact runs on Ubuntu bionic with minimal configuration
>
> Thanks for creating the new build, Ferenc!
>
> Mike
>
> On Mon, Dec 17, 2018 at 12:41 PM Ferenc Szabo <szabofe...@apache.org>
wrote:
>
> > Dear Flume Community,
> >
> > This is the 12th release for Apache Flume as a top-level project,
> > version 1.9.0. We are voting on release candidate RC3.
> >
> > It fixes the following issues:
> >
> >
https://raw.githubusercontent.com/apache/flume/release-1.9.0-rc3/CHANGELOG
> >
> > *** Please cast your vote within the next 72 hours ***
> >
> > The tarball (*.tar.gz), signature (*.asc), and checksums (*.sha512)
> > for the source and binary artifacts can be found here:
> >   http://people.apache.org/~szaboferee/apache-flume-1.9.0-rc3/
> >
> > Maven staging repo:
> >
https://repository.apache.org/content/repositories/orgapacheflume-1032/
> >
> > The tag to be voted on:
> >
> >
> >
https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=d4fcab4f501d41597bc616921329a4339f73585e
> >
> > Flume's KEYS file containing PGP keys we use to sign the release:
> >   https://svn.apache.org/repos/asf/flume/dist/KEYS
> >
> >
> > Regards,
> > Ferenc
> >

Reply via email to