AndreLouisCaron commented on a change in pull request #320: Fix issues reported
by SpotBugs in ElasticSearch sink
URL: https://github.com/apache/flume/pull/320#discussion_r398988455
##########
File path:
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java
##########
@@ -419,7 +413,7 @@ private long parseTTL(String ttl) {
} else if (matcher.group(2).equals("d")) {
return TimeUnit.DAYS.toMillis(Integer.parseInt(matcher.group(1)));
} else if (matcher.group(2).equals("w")) {
- return TimeUnit.DAYS.toMillis(7 * Integer.parseInt(matcher.group(1)));
Review comment:
Note to reviewers: SpotBugs was reporting
`ICAST_INTEGER_MULTIPLY_CAST_TO_LONG`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
