AndreLouisCaron commented on a change in pull request #320: Fix issues reported
by SpotBugs in ElasticSearch sink
URL: https://github.com/apache/flume/pull/320#discussion_r398988763
##########
File path:
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
##########
@@ -71,7 +71,6 @@ public ElasticSearchClient getLocalClient(String clientType,
return new ElasticSearchTransportClient(serializer);
} else if (clientType.equalsIgnoreCase(TransportClient) && indexBuilder !=
null) {
return new ElasticSearchTransportClient(indexBuilder);
- } else if (clientType.equalsIgnoreCase(RestClient)) {
Review comment:
Note to reviewers: SpotBugs was reporting `UCF_USELESS_CONTROL_FLOW`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
