ugh, okay, consider this vote rescinded. I'll put together an RC2 after we revert the formatter plugin in the parent POM back to 2.7.0. Thanks for confirming, Keith.
On Fri, Nov 17, 2017 at 4:58 PM Keith Turner <ke...@deenlo.com> wrote: > I tried version 2.7.0 of the formatter plugin and it worked fine. > > On Thu, Nov 16, 2017 at 8:42 PM, Christopher <ctubb...@apache.org> wrote: > > Here's an overview of voting at Apache: > > https://www.apache.org/foundation/voting.html > > > > In short, only PMC votes are binding, but other non-binding votes are > > certainly welcome. They help inform what the wider audience thinks about > a > > release candidate, and more voting typically means more testing. > > > > Often, when people vote, they also provide information about what they > > tried/tested, in order to arrive at their vote. > > > > My current vote is -1: I ran into > > https://github.com/revelc/formatter-maven-plugin/issues/260 while > testing > > this on the master branch of Fluo. I'm not sure what's wrong. If I can't > > get it to work (or if somebody else also has the same problem), I'll > > withdraw this vote, and do a PR to revert back to 2.7.0 of the formatter, > > which I've tested on Fluo and works fine. There's supposedly an enum > > formatting bug fix in 2.7.1, which I had wanted to include here, but it > > doesn't seem to affect Fluo, so version 2.7.0 should suffice until we > > figure out what's wrong with 2.7.1. > > > > On Thu, Nov 16, 2017 at 7:56 PM kenneth mcfarland < > > kennethpmcfarl...@gmail.com> wrote: > > > >> I am unfamiliar with voting, if non pmc can cast votes. > >> > >> But if I could it will be a +1. > >> > >> Very nice work. > >> > >> On Nov 16, 2017 4:43 PM, "Christopher" <ctubb...@apache.org> wrote: > >> > >> > Fluo Developers, > >> > > >> > Please consider the following candidate for Fluo Parent POM 3. I've > >> > prepared this release candidate primarily because of the fact that > >> version > >> > 2 uses a formatter that does not properly format javadocs. This was > >> fixed, > >> > and numerous other improvements were made in upstream versions of > >> > formatter-maven-plugin, to support Java 1.8 and lambdas, by using > Eclipse > >> > Oxygen.1a's formatter. > >> > > >> > Git Commit: > >> > 7e0a2ee9ebd7f988fc4f6756a2df72d5f2cf8741 > >> > Branch: > >> > fluo-parent-3-rc1 > >> > > >> > If this vote passes, a gpg-signed tag will be created using: > >> > git tag -f -m 'Apache Fluo Parent POM 3' -s rel/fluo-parent-3 \ > >> > 7e0a2ee9ebd7f988fc4f6756a2df72d5f2cf8741 > >> > > >> > Staging repo: > >> > https://repository.apache.org/content/repositories/orgapachefluo-1020 > >> > Source (official release artifact): > >> > https://repository.apache.org/content/repositories/ > >> > orgapachefluo-1020/org/apache/fluo/fluo-parent/3/fluo- > >> > parent-3-source-release.tar.gz > >> > > >> > (Append ".sha1", ".md5", or ".asc" to download the signature/hash for > a > >> > given artifact.) > >> > > >> > All artifacts were built and staged with: > >> > mvn release:prepare && mvn release:perform > >> > > >> > Signing keys are available at https://www.apache.org/dist/fluo/KEYS > >> > (Expected fingerprint: 8CC4F8A2B29C2B040F2B835D6F0CDAE700B6899D) > >> > > >> > Please vote one of: > >> > [ ] +1 - I have verified and accept... > >> > [ ] +0 - I have reservations, but not strong enough to vote against... > >> > [ ] -1 - Because..., I do not accept... > >> > ... these artifacts as the 3 release of Apache Fluo Parent POM. > >> > > >> > This vote will remain open until at least Mon Nov 20 01:00:00 UTC 2017 > >> > (Sun Nov 19 20:00:00 EST 2017 / Sun Nov 19 17:00:00 PST 2017). > >> > Voting can continue after this deadline until the release manager > sends > >> an > >> > email ending the vote. > >> > > >> > Thanks! > >> > > >> > P.S. Hint: download the whole staging repo with > >> > wget -erobots=off -r -l inf -np -nH \ > >> > > >> https://repository.apache.org/content/repositories/orgapachefluo-1020/ > >> > # note the trailing slash is needed > >> > > >> >
