Tuesday, March 22, 2016, 9:44:31 AM, Sergio Fernández wrote: > +1 (binding) for both releases. > > So far I've checked: > > * signatures and digests > * source releases file layouts > * matched git tags and commit ids > * incubator suffix and disclaimer > * NOTICE and LICENSE files > * build sources in a clean environment (Oracle JDK 1.8.0_74, Debian amd64) > > Things could be polished for future releases (all non-blocking, > probably more question for discussion than issues actually): > > * Test binaries distributed in the source release (taglib 2.jar, > taglib-foo.jar, templates.jar); I do not know enough the project, > but should be a way to make test dependencies with Ivy.
Those aren't binaries, but directories. They were binaries in RC01, but now they are directories that the test packs into jars on the fly. > * The same it could be applied for *.dtd files, but I guess there > is a strong need of distributing them. I hope we can drop them all together (https://issues.apache.org/jira/browse/FREEMARKER-17). > * Having a RELEASE-NOTES file I think we could include the actual > notes in the source release, not just linking to the web or to a file in the > binary release. The version history is quite long, and contains links to Manual sections without which it's much less usable, also some formatting. So I don't want to burn resources on maintaining a plain text version. But I thought we should still give at least a pointer at the standard location, in the RELEASE-NOTES file. > Besides that, great work guys! The first incubating release is > always hard, but with 2.3.24-rc01-incubating we already made quite some > progress. > > Cheers, > > > On Mon, Mar 21, 2016 at 12:02 AM, Daniel Dekany <ddek...@freemail.hu> wrote: > Hi all, > > Please vote on releasing FreeMarker 2.3.24-incubating! This will be > our first stable release (not just a Release Candidate) from the ASF. > If this voting passes, another similar voting will be started on > gene...@incubator.apache.org, and if that passes too, then we can > release this version. > > Release Notes: > http://freemarker.org/builds/2.3.24-unvoted/_html/versions_2_3_24.html > > Before proceed, you should know that FreeMarker 2.3.x, for a long > time, always releases a normal and a "gae" variant on the same time, > which are technically two independent source trees (Git branches). The > "gae" variant contains a few small modification in the Java source > code to be Google App Engine compliant, and has freemarker-gae as the > Maven artifact name. Otherwise the normal and the "gae" branches are > identical. Hence they will be voted on together. > > The commits to be voted upon are: > - Normal (non-gae) variant: > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=4a723fc1e89c3f258b00e6ee40ba3c60d076aa89 > Commit hash: 4a723fc1e89c3f258b00e6ee40ba3c60d076aa89 > - "gae" variant: > > https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker.git;a=commit;h=4b8df1fd03c21495e646ac1721734811564317f5 > Commit hash: 4b8df1fd03c21495e646ac1721734811564317f5 > > The artifacts to be voted upon are located here: > https://dist.apache.org/repos/dist/dev/incubator/freemarker/engine/2.3.24-incubating/source/ > where the source release artifacts are: > - Normal (non-gae) variant: > apache-freemarker-2.3.24-incubating-src.tar.gz > - "gae" variant: > apache-freemarker-gae-2.3.24-incubating-src.tar.gz > > See the README inside them for build instructions! > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/ddekany.asc > > Note that for convenience, we also provide binaries: > https://dist.apache.org/repos/dist/dev/incubator/freemarker/engine/2.3.24-incubating/binaries/ > and Maven artifacts in the ASF staging repository: > https://repository.apache.org/content/repositories/staging/org/freemarker/ > > Please try out the package and vote! > > The vote is open for a minimum of 72 hours or until the necessary number of > votes (3 binding +1s) is reached. > > [ ] +1 Release this package as Apache FreeMarker 2.3.24-incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Please add "(binding)" if your vote is binding. > > -- > Thanks, > Daniel Dekany > > > > -- Thanks, Daniel Dekany
