[jira] [Commented] (GEARPUMP-153) throw exceptions on main class load failure

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/GEARPUMP-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313839#comment-15313839
 ] 

ASF GitHub Bot commented on GEARPUMP-153:
-----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/34
  
    ## [Current coverage][cc-pull] is **64.16%**
    > Merging [#34][cc-pull] into [master][cc-base-branch] will increase 
coverage by **0.63%**
    
    1. 2 files (not in diff) in `...he/gearpump/jarstore` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F6A617273746F7265)
 
      - Misses `+8` 
      - Hits `-8`
    1. 2 files (not in diff) in `...mp/cluster/scheduler` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F7363686564756C6572)
    1. 3 files (not in diff) in `...rpump/cluster/master` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D6173746572)
 
      - Misses `+75` 
      - Hits `-75`
    1. 3 files (not in diff) in `...earpump/cluster/main` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D61696E)
    1. 1 files (not in diff) in `...che/gearpump/cluster` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572)
 
      - Misses `+1` 
      - Hits `-1`
    1. 1 files (not in diff) in `.../org/apache/gearpump` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D70)
    1. 6 files (not in diff) in `...apache/gearpump/util` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C)
 
      - Misses `-32` 
      - Hits `+32`
    1. 2 files (not in diff) in `...rpump/cluster/client` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F636C69656E74)
 
      - Misses `-43` 
      - Hits `+43`
    1. 2 files (not in diff) in `...mp/cluster/appmaster` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6170706D6173746572)
 
      - Misses `-9` 
      - Hits `+9`
    1. 7 files (not in diff) in `...che/gearpump/cluster` were modified. 
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572)
 
      - Misses `-36` 
      - Hits `+36`
    
    ```diff
    @@             master        #34   diff @@
    ==========================================
      Files           178        178          
      Lines          5922       5923     +1   
      Methods        5644       5651     +7   
      Messages          0          0          
      Branches        278        272     -6   
    ==========================================
    + Hits           3761       3800    +39   
    + Misses         2161       2123    -38   
      Partials          0          0          
    ```
    
    
[![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/34/graphs/sunburst.svg?size=150&src=pr)][cc-pull]
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[ec04cf7...d724ad6][cc-compare]
    [cc-base-branch]: 
https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
    [cc-compare]: 
https://codecov.io/gh/apache/incubator-gearpump/compare/ec04cf7666020ba15764611ac872344549f5200c...d724ad6b9ff1d6c128abcd62f2eb7fd0394c4ecb
    [cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/34?src=pr


> throw exceptions on main class load failure
> -------------------------------------------
>
>                 Key: GEARPUMP-153
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-153
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>            Priority: Minor
>
> Currently, if user provided main class is not loaded successfully, the 
> exception is swallowed and the main class specified in manifest will be 
> loaded. This hides the problem from users, and they'll be confused why their 
> intended main class cannot be loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)