[ https://issues.apache.org/jira/browse/GEARPUMP-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313840#comment-15313840 ]
ASF GitHub Bot commented on GEARPUMP-153: ----------------------------------------- Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/34#discussion_r65672571 --- Diff: daemon/src/main/scala/org/apache/gearpump/cluster/main/AppSubmitter.scala --- @@ -95,7 +94,8 @@ object AppSubmitter extends AkkaApp with ArgumentsParser { val mainInManifest = Option(new JarFile(jar).getManifest.getMainAttributes. getValue("Main-Class")).getOrElse("") - if (remainArgs.length > 0 && Try(classLoader.loadClass(remainArgs(0))).isSuccess) { + if (remainArgs.length > 0) { --- End diff -- What if I submit wordcount without the mainclass but specify other arguments? > throw exceptions on main class load failure > ------------------------------------------- > > Key: GEARPUMP-153 > URL: https://issues.apache.org/jira/browse/GEARPUMP-153 > Project: Apache Gearpump > Issue Type: Improvement > Affects Versions: 0.8.0 > Reporter: Manu Zhang > Assignee: Manu Zhang > Priority: Minor > > Currently, if user provided main class is not loaded successfully, the > exception is swallowed and the main class specified in manifest will be > loaded. This hides the problem from users, and they'll be confused why their > intended main class cannot be loaded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)