> On Feb. 8, 2017, 5:02 p.m., Kevin Duling wrote:
> > `File.getParentFile()` may return null. For example, assume your working
> > directory is "/tmp". The call to
> > `File(".").getParentFile().getParentFile()` will return null.
>
> Jared Stewart wrote:
> When you are running a test inside the "geode-assembly" module, new
> File(".") will yield "geode/geode-assembly/." so that calling
> .getParentFile() twice will give you "geode" (the directory where geode is
> checked out, probably called "open" for many of us). This works through
> IntelliJ and Gradle so it doesn't seem like an issue to me.
>
> Kevin Duling wrote:
> I think it should be using GEODE_HOME as `BundledJarsJUnitTest` does.
This method is used to set GEMFIRE_HOME when none is already set.
BundledJarsJUnitTest fails when I try to run it in my IDE since I don't have
any GEODE_HOME/GEMFIRE_HOME set.
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56425/#review164702
-----------------------------------------------------------
On Feb. 8, 2017, 3:03 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56425/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:03 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2272: do not use a new method to start locator with pulse
>
>
> Diffs
> -----
>
>
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
> b5472909eec8d5ca124e7bfd5c6cb71864d9bbee
>
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> 1f0cd9e720e732c2ce06515c16601e1df173ff4f
>
> Diff: https://reviews.apache.org/r/56425/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinmei Liao
>
>
