> On Feb. 8, 2017, 7:49 p.m., Kirk Lund wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java,
> > line 172
> > <https://reviews.apache.org/r/56425/diff/1/?file=1627169#file1627169line172>
> >
> > Another use of setting "gemfire.home" system property. I don't know
> > what the correct approach is but I think this is wrong.
I think the correct thing to do is to let Gradle set GEODE_HOME for the tests
to pick up.
We do this already apparently, although the value we set for GEODE_HOME looks
wrong to me.
```
tasks.withType(Test){
environment 'GEODE_HOME',
"$buildDir/install/${distributions.main.baseName}/lib"
}
```
I would expect GEODE_HOME to not have the "/lib" portion on the end, and
AgentUtil (which finds the pulse war) is expecting the same thing.
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56425/#review164751
-----------------------------------------------------------
On Feb. 8, 2017, 3:03 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56425/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:03 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2272: do not use a new method to start locator with pulse
>
>
> Diffs
> -----
>
>
> geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java
> b5472909eec8d5ca124e7bfd5c6cb71864d9bbee
>
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> 1f0cd9e720e732c2ce06515c16601e1df173ff4f
>
> Diff: https://reviews.apache.org/r/56425/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinmei Liao
>
>
