----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56769/#review165880 -----------------------------------------------------------
Ship it! Ship It! geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java (line 108) <https://reviews.apache.org/r/56769/#comment237713> does it matter if we use chunk vs file bucket here? - Jason Huynh On Feb. 16, 2017, 9:17 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56769/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 9:17 p.m.) > > > Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > 1) Since we have the partition listener on the chunk bucket, we should > be looking at the chunk bucket to tell if we are primary, not the file > bucket > > 2) We were not cleaning up the dlock in some cases if the bucket moved. > > 3) The dlock name was confusing, because we took the bucket name, eg > file_B_1, and added the bucket id to it. So we had a lock name like > file_B_11 for bucket 1. > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java > 57dd0a56882b4087770348c3f58df29df9fdc893 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java > f1ee9871911f7ecfd3084c464ed8b67e9f28800a > > Diff: https://reviews.apache.org/r/56769/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
