Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103928210
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -259,6 +307,16 @@ public void
createRemoteRegionReferenceLocally(ByteArrayWrapper key, RedisDataTy
private Region<?, ?> getOrCreateRegion0(ByteArrayWrapper key,
RedisDataType type,
ExecutionHandlerContext context, boolean addToMeta) {
+
+ String regionName = key.toString();
+
+ // check if type is hash TODO: remove
--- End diff --
I think we can safely remove this TODO comment.
The special processing for hashing is now handled at the HashExecutor
(along with its sub-classes) commands level. It does not need to be handled at
the RegionProvider level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
