[
https://issues.apache.org/jira/browse/GEODE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895108#comment-15895108
]
ASF GitHub Bot commented on GEODE-1793:
---------------------------------------
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/412
GEODE-1793 LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOther…
This was a product issue. When the locator using plain-text sockets is
contacted by a TcpClient using SSL the locator often just closes the socket.
On some platforms this causes a SSLHandshakeException but on others it
just causes a "SocketException: connection reset". Writing some text to
the socket forces the TcpClient to get a SSLException (which is the
superclass
of SSLHandshakeException).
The test class is still marked as Flaky due to GEODE-2542.
I deleted one of the tests in LocatorDUnitTest as it wasn't doing any
useful validation and really served no purpose.
I also increased the joinTimeout in this test. The original 1-second
timeout was intended to make the tests run faster but I think it's probably the
source of some of the flaky-ness in this set of tests. Some of them were also
overriding the joinTimeout established by the DUnit framework, so that was
actually a bad thing to be doing. The tests all run in a few seconds with the
default joinTimeout setting anyway.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-1793
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/412.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #412
----
commit 866dc5ca1583c5fab49ec96c48d261c0367427f3
Author: Bruce Schuchardt <[email protected]>
Date: 2017-03-03T21:47:42Z
GEODE-1793 LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
This was a product issue. When the locator using plain-text sockets is
contacted by a TcpClient using SSL the locator often just closes the socket.
On some platforms this causes a SSLHandshakeException but on others it
just causes a "SocketException: connection reset". Writing some text to
the socket forces the TcpClient to get a SSLException (which is the
superclass
of SSLHandshakeException).
The test class is still marked as Flaky due to GEODE-2542.
----
> Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
> -----------------------------------------------------------------------
>
> Key: GEODE-1793
> URL: https://issues.apache.org/jira/browse/GEODE-1793
> Project: Geode
> Issue Type: Bug
> Components: locator
> Reporter: Udo Kohlmeyer
> Assignee: Galen O'Sullivan
> Priority: Minor
>
> This test fails due to something not cleaning itself properly. Undetermined
> what the problem is, but it will run perfectly by itself everytime, but once
> run inside of the TestClass it fails
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
