[
https://issues.apache.org/jira/browse/GEODE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895201#comment-15895201
]
ASF GitHub Bot commented on GEODE-1793:
---------------------------------------
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104260160
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -360,6 +360,13 @@ private void processRequest(final Socket sock) {
versionOrdinal = (short)
GOSSIP_TO_GEMFIRE_VERSION_MAP.get(gossipVersion);
} else {
// Close the socket. We can not accept requests from a newer
version
+ try {
+ sock.getOutputStream().write("unknown protocol
version".getBytes());
--- End diff --
This situation should never happen. When we fetch the protocol version of
a Locator we use v5.7. Then we use the locator's protocol version in future
communications. We will never send a higher version number than the locator
knows how to handle.
For SSL, this text is nothing like the response to a HelloClient packet.
On machines I've tested on it results in either a SSLHandshakeException or a
SSLException hinting that the other end might be using plain text sockets.
> Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
> -----------------------------------------------------------------------
>
> Key: GEODE-1793
> URL: https://issues.apache.org/jira/browse/GEODE-1793
> Project: Geode
> Issue Type: Bug
> Components: locator
> Reporter: Udo Kohlmeyer
> Assignee: Galen O'Sullivan
> Priority: Minor
>
> This test fails due to something not cleaning itself properly. Undetermined
> what the problem is, but it will run perfectly by itself everytime, but once
> run inside of the TestClass it fails
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
