Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107995174
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult {
public:
inline ChunkedFunctionExecutionResponse(
- TcrMessage& msg, bool getResult, ResultCollectorPtr rc,
- ACE_Recursive_Thread_Mutex* resultCollectorLock = NULL)
+ TcrMessage& msg, bool getResult, ResultCollectorPtr rc)
: TcrChunkedResult(),
m_msg(msg),
m_getResult(getResult),
- m_rc(rc),
- m_resultCollectorLock(resultCollectorLock) {}
-
+ m_rc(rc) {}
+
+ inline ChunkedFunctionExecutionResponse(
+ TcrMessage& msg, bool
getResult, ResultCollectorPtr rc,
+
std::shared_ptr<ACE_Recursive_Thread_Mutex> resultCollectorLock)
+ : TcrChunkedResult(),
+ m_msg(msg),
+ m_getResult(getResult),
+ m_rc(rc),
+ m_resultCollectorLock(resultCollectorLock) {}
+
--- End diff --
fun fact: line 433 has dangling white space that the Github diff tool is
choosing to ignore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
