Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006150
--- Diff: src/cppcache/src/ThinClientPoolDM.hpp ---
@@ -463,7 +463,8 @@ class FunctionExecution : public PooledWork<GfErrType> {
void setParameters(const char* func, uint8_t getResult, uint32_t timeout,
CacheablePtr args, TcrEndpoint* ep,
- ThinClientPoolDM* poolDM, ACE_Recursive_Thread_Mutex*
rCL,
+ ThinClientPoolDM* poolDM,
+ std::shared_ptr<ACE_Recursive_Thread_Mutex> rCL,
--- End diff --
Why not `const std::shared_ptr<ACE_Recursive_Thread_Mutex>& rCL`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
