> On May 11, 2017, 9:38 p.m., Darrel Schneider wrote: > > Instead of having CacheLoader extend Declarable I think you should have > > changed CacheCallback to extends Declarable. > > CacheLoader is too narrow. So is CacheLoader and CacheListener. I know the > > jira ticket focused on CacheLoader and mentioned CacheListener in its > > description but we have lots of things that can be declared on cache.xml > > and I think CacheCallback covers them all.
Good point, I've uploaded a new diff to make this change. - Jared ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/#review174733 ----------------------------------------------------------- On May 11, 2017, 9:16 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59206/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 9:16 p.m.) > > > Review request for geode. > > > Repository: geode > > > Description > ------- > > GEODE-2836: CacheLoader now extends Declarable > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/cache/CacheLoader.java > 88128166fa24a4160d28f478e4e546a1e1dbf335 > geode-core/src/main/java/org/apache/geode/cache/Declarable.java > 57e1e6316395a62588fac430b1f807684b3335fb > > > Diff: https://reviews.apache.org/r/59206/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
