Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119220596
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1794,18 +1801,20 @@ public Result statusServer(
.format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache
Server"));
}
} else {
- final ServerLauncher serverLauncher = new ServerLauncher.Builder()
-
.setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging())
- // NOTE since we do not know whether the "CacheServer" was
enabled or not on the GemFire
- // server when it was started, set the disableDefaultServer
property in the
- // ServerLauncher.Builder to default status
- // to the MemberMBean
- // TODO fix this hack! (how, the 'start server' loop needs it)
-
.setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory)
- .build();
-
+ final ServerLauncher serverLauncher;
+ if ((member == null)) {
--- End diff --
It looks like we're guaranteed that `member` is not blank in this `else`
block, so I think we are guaranteed that `member` is not null here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
