Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/549#discussion_r119231037
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
    @@ -2747,6 +2749,8 @@
       public static final String STATUS_SERVER__DIR = "dir";
       public static final String STATUS_SERVER__DIR__HELP =
           "Working directory in which the Cache Server is running. The default 
is the current directory.";
    +  public static final String 
STATUS_SERVER__NO_SERVER_SPECIFIED_ERROR_MESSAGE =
    --- End diff --
    
    I believe the `running in %2$s` portion of this output is going to be 
misleading when the status locator command has omitted the `workingDirectory` 
option.  For example, if I ask for the status of a remote locator by specifying 
its hostname and port, this message will suggest that we expect the locator to 
be running in the current directory on the GFSH client machine.  It might also 
be helpful for this message to explain *why* we are unable to determine the 
status of this Locator.  Maybe something like  "At least one of the following 
options must be specified:  `--name`, `--host`, or `--port`.   Use 'help status 
server' to display detailed usage information." would be more helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to