Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130958981
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -260,6 +265,7 @@ private JMXServiceURL getJMXServiceURL() throws
AttachNotSupportedException, IOE
// need to load the management-agent and get the address
final String javaHome =
vm.getSystemProperties().getProperty("java.home");
+ assertState(StringUtils.isNotBlank(javaHome),
CliStrings.JAVA_HOME_NOT_FOUND_ERROR_MESSAGE);
--- End diff --
You're right... I was trying to find a place for the
`JAVA_HOME_NOT_FOUND_ERROR_MESSAGE` variable, but it looks like it would change
some behavior if inserted here. I'll just roll back the changes on this file
and delete `JAVA_HOME_NOT_FOUND_ERROR_MESSAGE`. Thanks for your feedback!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
