Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130959557
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java
---
@@ -99,7 +99,6 @@ protected Launcher() {
this.allowedCommandLineCommands.add(CliStrings.START_JCONSOLE);
this.allowedCommandLineCommands.add(CliStrings.START_JVISUALVM);
this.allowedCommandLineCommands.add(CliStrings.START_LOCATOR);
- this.allowedCommandLineCommands.add(CliStrings.START_MANAGER);
--- End diff --
Sure! Almost none of the `--- manager` CliStrings were used, so I deleted
them. Only `start manager` was ever used, and only in this place, so I figured
it would be safe to get rid of it. Do you think this might break any backwards
compatibility / should I roll back the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
