I ran rat manually and got this: Files with unapproved licenses:
/geode/.cpackignore /geode/.lcovrc /geode/clicache/src/native_shared_ptr.hpp /geode/templates/security/CMakeLists.txt.forInstall Shouldn’t these failures be causing travis to fail? Many of the files rat that marks as binary have this the annoying BOM [1] from visual studio. Seems like we should just remove those. That will reveal a number of files that need a license header. What is this file? Seems to be binary content: clicache/test/native_shared_ptrTests.cpp I also noticed this text that should be updated to point to where we intend to host the documentation (on the geode website): docs/README.md:The Geode-Native repository provides the full source for the Apache Geode Native Client User Guide in markdown format (see _geode-project-dir_/geode-docs/CONTRIBUTE.md for more information on how to use markdown in this context). Users can build the markdown into an HTML user guide using [Bookbinder](https://github.com/pivotal-cf/bookbinder) and the instructions below. docs/api/unix_index.html:Access documentation at <a href="http://docs-gemfire-nativeclient-develop.cfapps.io" target="_blank"><b>Pivotal GemFire Native Client Documentation</b></a>. docs/api/win_index.html:Access documentation at <a href="http://docs-gemfire-nativeclient-develop.cfapps.io" target="_blank"><b>Pivotal GemFire Native Client Documentation</b></a>. Anthony [1] https://en.wikipedia.org/wiki/Byte_order_mark > On Oct 29, 2018, at 12:11 PM, Jacob Barrett <jbarr...@pivotal.io> wrote: > > There are a lot of files that rat is seeing as binary files and ignoring > the headers. Many of those files are not binary. Perhaps they have the > wrong metadata associated with them in git as a result of bad commits. We > should clean all those files up so that rat is checking everything > correctly. > > On Thu, Oct 18, 2018 at 3:41 PM Dan Smith <dsm...@pivotal.io> wrote: > >> Following up on this - is there anything we still need to do before we cut >> the 1.8 release branch in 2 weeks? >> >> Overall I think the native client source code looks like it's in good shape >> - we're running rat, the LICENSE and NOTICE look good, no binaries in the >> source, etc. >> >> For cutting the release branch, do we have criteria other than passing >> travis [1] ? >> What will our release steps should look like for the native client - just >> tar up the source and sign it with gpg? >> >> If we can have this figured out ahead of time and at least provisionally >> added to the release steps [2] I think it will help this release go a >> little smoother. >> >> [1] https://travis-ci.org/apache/geode-native/branches >> [2] >> https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode >> >> On Thu, Oct 11, 2018 at 3:23 PM Dan Smith <dsm...@pivotal.io> wrote: >> >>> +1 for a source release. Awesome! >>> >>> -Dan >>> >>> On Thu, Oct 11, 2018 at 2:32 PM Michael Oleske <mole...@pivotal.io> >> wrote: >>> >>>> Plus 1 for source release. Exciting times we live in! >>>> >>>> For verifying, plus one to a pipeline that's not just travis. Though >>>> they're instructions in the repo about how to run tests to get that >>>> baseline confidence. >>>> >>>> -michael >>>> >>>> On Wednesday, October 10, 2018, Anilkumar Gingade <aging...@pivotal.io> >>>> wrote: >>>> >>>>> Good work team. >>>>> +1 to get this as part of Geode 1.8 release. >>>>> It will be good to see community taking advantage of this. And >> building >>>> new >>>>> native client apps. >>>>> I assume it will have all the docs about client-server compatibility >>>>> version info. And framework for backward compatibility testing with >> new >>>>> geode releases. >>>>> >>>>> -Anil. >>>>> >>>>> >>>>> >>>>> On Wed, Oct 10, 2018 at 12:02 PM Ernest Burghardt < >>>> eburgha...@pivotal.io> >>>>> wrote: >>>>> >>>>>> +1 for a source release >>>>>> >>>>>> >>>>>> On Wed, Oct 10, 2018 at 12:59 PM Anthony Baker <aba...@pivotal.io> >>>>> wrote: >>>>>> >>>>>>> I think starting with a source-only release of the native client >> is >>>> a >>>>>> good >>>>>>> first step. That lets us focus on verifying that all the tasks >>>>> outlined >>>>>> in >>>>>>> [1] are complete and correct. >>>>>>> >>>>>>> Anthony >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/GEODE-1416 >>>>>>> >>>>>>> >>>>>>>> On Oct 10, 2018, at 11:52 AM, Dan Smith <dsm...@pivotal.io> >>>> wrote: >>>>>>>> >>>>>>>> That is awesome! Let's get it in! >>>>>>>> >>>>>>>> I think there are some details to work out: >>>>>>>> - Do we need to build any automation for creating the native >>>> source >>>>>>>> release (similar to ./gradlew srcDist on the java side)? >>>>>>>> - Will we release binaries? Which platforms and how to does the >>>>> release >>>>>>>> manager build them? >>>>>>>> - How do we verify the NC code - can we create a public >> pipeline? >>>>>>>> >>>>>>>> Shipping these native APIs will be a great improvement! >>>>>>>> >>>>>>>> -Dan >>>>>>>> >>>>>>>> On Wed, Oct 10, 2018 at 8:41 AM Addison Huddy < >> ahu...@pivotal.io> >>>>>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> The Geode Native components ( >>>> https://github.com/apache/geode-native >>>>> ) >>>>>>> have >>>>>>>>> made tremendous progress since its original donation to Apache. >>>> The >>>>>>>>> project is nearing a release candidate and I propose that the >>>> *first >>>>>>>>> official release of Geode Native be included in Apache Geode >>>> 1.8.* >>>>>>>>> >>>>>>>>> Since donation, the project has >>>>>>>>> >>>>>>>>> - modernized its C++ API based on C++ 11 standards >>>>>>>>> - refactored away the cache singleton to allow for more >>>> flexible >>>>>>>>> architectures and client-side data modeling >>>>>>>>> - refactored the serializable interfaces (DataSerializable, >>>>>>>>> PdxSerializable, DataSerializableFixedId) to make object >>>>>> serialization >>>>>>>>> more straight-forward >>>>>>>>> - created several examples on how to use the client ( >>>>>>>>> https://github.com/apache/geode-native/tree/develop/examples >> ) >>>>>>>>> >>>>>>>>> In all, the project has closed 285 JIRA tickets since donation. >>>>>>>>> >>>>>>>>> If you want to learn more about the Geode Native, check out >> these >>>>> two >>>>>>>>> Apache Geode By Example videos. >>>>>>>>> >>>>>>>>> .NET: https://www.youtube.com/watch?v=-LQYNJNQ7B4&t=3s >>>>>>>>> >>>>>>>>> C++: https://www.youtube.com/watch?v=KJciEcFRdtY&t=1s >>>>>>>>> >>>>>>>>> Looking forward to hearing your input on including the first >> cut >>>> of >>>>>>> Geode >>>>>>>>> Native in Apache Geode 1.8. >>>>>>>>> >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Addison >>>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>