This is a great idea! On thought though, did you consider just converting the existing PoolManager to an interface leaving the static methods intact but deprecated? I would think this would make existing code pretty easy to refactor over to the new code with minimal changes. If you thought about it can you add why you rejected it to the RFC.
-Jake > On Dec 5, 2019, at 4:40 PM, Dan Smith <dsm...@pivotal.io> wrote: > > Hi, > > I wrote up a proposal for deprecating of the singleton PoolManager in favor > of a ClientCache scoped service. Please review and comment on the below > proposal. > > I think this should address the issues that Spring Data Geode and friends > had trying to mock Pools and remove the need for those projects to try to > inject mock Pools into a Geode singleton. > > https://cwiki.apache.org/confluence/display/GEODE/Replace+singleton+PoolManager+with+ClientCache+scoped+service > > Thanks, > -Dan
