> On July 10, 2015, 11:41 p.m., Jason Huynh wrote: > > gemfire-spark-connector/project/Dependencies.scala, line 9 > > <https://reviews.apache.org/r/36408/diff/1/?file=1008785#file1008785line9> > > > > From my understanding, I think the long term plan is to no longer use a > > repo and instead rely on the spark gemfire connector being built within the > > geode build. Then add a dependency on the geode jar file from the build > > artifacts. > > > > Then the instructions about building and such would be unnecessary. > > The Integration tests would be modified to not use a GEODE location and > > instead just use the build artifacts as well. > > > > I think we should make the leap to this new model unless it's necessary > > for this intermediate step...
I agree with the long term plan. However, there is immediate concern. The current code does not build, unless we make some change. We can make it work, then work on the long term plan. - Jianxia ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36408/#review91374 ----------------------------------------------------------- On July 10, 2015, 11:32 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36408/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 11:32 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, > and Qihong Chen. > > > Repository: geode > > > Description > ------- > > Remove the dependency on Pivotal's internal repo. > > Resolve the conflict of different netty versions on Spark and Geode. > > To build Geode Spark Connector, first build Geode and publish the jars to > local repo. Then you build the connector using sbt. > > > Diffs > ----- > > gemfire-spark-connector/doc/1_building.md ece4a9c > gemfire-spark-connector/project/Dependencies.scala 899e182 > gemfire-spark-connector/project/Settings.scala ec61884 > > Diff: https://reviews.apache.org/r/36408/diff/ > > > Testing > ------- > > sbt test it:test > > > Thanks, > > Jianxia Chen > >
