----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36957/#review93674 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java (line 64) <https://reviews.apache.org/r/36957/#comment148088> super.isDebugEnabled should be super.isTraceEnabled gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java (line 75) <https://reviews.apache.org/r/36957/#comment148089> super.isDebugEnabled should be super.isTraceEnabled - Darrel Schneider On July 30, 2015, 3:18 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36957/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 3:18 p.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: GEODE-181 and GEODE-89 > https://issues.apache.org/jira/browse/GEODE-181 > https://issues.apache.org/jira/browse/GEODE-89 > > > Repository: geode > > > Description > ------- > > I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for > GEODE-89. These changes address both tickets. > > Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest. > > Refactor remaining test in FastLoggerJUnitTest to improve coverage and > readability. Introduce use of TemporaryFolder instead of using tmp dir. > Change from UnitTest to IntegrationTest because of file system I/O and > execution speed. > > Add new TestSuite classes for targeted testing of logging and log4j packages. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java > 21d7965 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java > 2aab5df > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36957/diff/ > > > Testing > ------- > > test, integrationTest, new TestSuites, rebuild open+closed > > > Thanks, > > Kirk Lund > >
