-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 8:32 p.m.)
Review request for geode and Darrel Schneider.
Bugs: GEODE-181 and GEODE-89
https://issues.apache.org/jira/browse/GEODE-181
https://issues.apache.org/jira/browse/GEODE-89
Repository: geode
Description
-------
I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for
GEODE-89. These changes address both tickets.
Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.
Refactor remaining test in FastLoggerJUnitTest to improve coverage and
readability. Introduce use of TemporaryFolder instead of using tmp dir. Change
from UnitTest to IntegrationTest because of file system I/O and execution speed.
Add new TestSuite classes for targeted testing of logging and log4j packages.
Diffs (updated)
-----
build.gradle c82e82a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
6298cf6
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
c7ae945
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
21d7965
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/DistributedSystemLogFileJUnitTest.java
9c7ba58
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
2aab5df
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
PRE-CREATION
Diff: https://reviews.apache.org/r/36957/diff/
Testing
-------
test, integrationTest, new TestSuites, rebuild open+closed
Thanks,
Kirk Lund
