----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37765/#review96388 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java (line 158) <https://reviews.apache.org/r/37765/#comment151729> Adding a sys prop makes this seem like a feature instead of a bug. Why not change to default behavior to have this bug fixed? Do you think the old way of doing it inline has value? gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java (line 4250) <https://reviews.apache.org/r/37765/#comment151723> do you want to change "bug 52530" to GEODE-278? gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java (line 4264) <https://reviews.apache.org/r/37765/#comment151721> clean up the "SWAP:" in multiple places in this test gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java (line 4304) <https://reviews.apache.org/r/37765/#comment151722> You should make sure this test always clears the system property. Even when the test fails earlier with an exception. Could you do the sys prop clear at the end in its own finally block? - Darrel Schneider On Aug. 25, 2015, 10:37 a.m., Swapnil Bawaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37765/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 10:37 a.m.) > > > Review request for geode and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > While applying changes to the Region, pass in List for gathering > pendingCallbacks > rather than a null on the remote members to get the same behavior as > transaction host. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java > f091570674f874539599b669af5d87290b329b18 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37765/diff/ > > > Testing > ------- > > > Thanks, > > Swapnil Bawaskar > >
