----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37765/#review96415 -----------------------------------------------------------
Ship it! Since you have changed the behavior instead of it being conditionally enabled make sure and run all the tests again. gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java (line 4321) <https://reviews.apache.org/r/37765/#comment151753> Since you got rid of the sys prop from the product shouldn't this go as well? - Darrel Schneider On Aug. 25, 2015, 1:01 p.m., Swapnil Bawaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37765/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 1:01 p.m.) > > > Review request for geode and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > While applying changes to the Region, pass in List for gathering > pendingCallbacks > rather than a null on the remote members to get the same behavior as > transaction host. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java > f091570674f874539599b669af5d87290b329b18 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37765/diff/ > > > Testing > ------- > > > Thanks, > > Swapnil Bawaskar > >
