----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41836/#review113145 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java (line 1361) <https://reviews.apache.org/r/41836/#comment173639> This method has other places it can throw exceptions. Also the caller of it has the same problem. The GemFireCacheImpl constructor may also throw exceptions that will not be logged. I think in general some code should be added when the constructor and init methods are called to catch all RuntimeExceptions or Errors and log them as an error before rethrowing them. - Darrel Schneider On Dec. 31, 2015, 1:09 p.m., Swapnil Bawaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41836/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 1:09 p.m.) > > > Review request for geode. > > > Repository: geode > > > Description > ------- > > While processing cache.xml, log an error before throwing an exception so > that the reason for cache close is clear by looking at the log. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java > 506bd7aeeb2c85105d19eaabf960c48639e6de24 > > Diff: https://reviews.apache.org/r/41836/diff/ > > > Testing > ------- > > > Thanks, > > Swapnil Bawaskar > >
