-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41836/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 7:22 p.m.)


Review request for geode and Darrel Schneider.


Changes
-------

Incorporating Darrel's feedback.


Repository: geode


Description
-------

- Catch all Errors and RuntimeExceptions while creating a cache and log
    an error level message.
    - Display the cache.xml contents before trying to initialize the cache
    so that the errors have a better context.
    - Converted some exception messages to i18n.


Diffs (updated)
-----

  
gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java
 c39e33a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java
 45adbd6 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 9d77556 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
2bc2f05 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PoolManagerImpl.java
 35b043f 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java
 780fe18 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml30DUnitTest.java
 adafa69 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml41DUnitTest.java
 5a41d31 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml57DUnitTest.java
 47bb612 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml60DUnitTest.java
 8699a05 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml66DUnitTest.java
 e531405 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java
 7fd2016 

Diff: https://reviews.apache.org/r/41836/diff/


Testing
-------


Thanks,

Swapnil Bawaskar

Reply via email to