Is there a good reason to use the Jenkins artifacts? Seems like it would be preferable to create artifacts from a clean working dir (or maybe fix Jenkins to put temporary files elsewhere).
The DISCLAIMER should look like this I believe: Apache Geode is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. Anthony > On Jan 6, 2016, at 4:01 PM, Niall Pemberton <niall.pember...@gmail.com> wrote: > > On Mon, Jan 4, 2016 at 10:43 PM, Nitin Lamba <ni...@ampool.io> wrote: > >> You're right Anthony - my bad. >> >> I did download the archive but accidentally opened the older tar.gz from >> April, 2015: >> geode-1.0.0.0-SNAPSHOT.src.tar.gz >> (the original source contributed to Apache). >> >> All's good now. Yes, did notice few extra folders but fixing that may be >> low priority. >> > > The extra folders will be a blocker because two of them contain external > jars > > - caches (contains dependency jar & class files) > - daemon > - native > - wrapper (contains gradle jar files) > > Also, incubator releases have to contain the DISCLAIMER, NOTICE & LICENSE > files - but perhaps thats being done in a separate branch. > > Niall > > >> - Nitin >> >> ________________________________________ >> From: Anthony Baker <aba...@pivotal.io> >> Sent: Monday, January 4, 2016 2:25 PM >> To: dev@geode.incubator.apache.org >> Subject: Re: Source distribution >> >> I wonder if we’re looking at different things?? >> >> When I download the night-build tarball at [1], I only found one Pivotal >> copyright: >> >> Anthony-Baker-MacBook-Pro:tmp abaker$ tar xf >> ~/Downloads/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar && grep -r >> Pivotal apache-geode-src-1.0.0-incubating-SNAPSHOT | grep -i copy >> apache-geode-src-1.0.0-incubating-SNAPSHOT/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/InstantiatorPropagationDUnitTest.java: >> * Copyright (c) 2010-2014 Pivotal Software, Inc. All Rights Reserved. >> >> In addition, I didn’t see gemfire-jgroups at all: >> >> Anthony-Baker-MacBook-Pro:tmp abaker$ tar xf >> ~/Downloads/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar && find >> apache-geode-src-1.0.0-incubating-SNAPSHOT -name "gemfire-jgroups" >> Anthony-Baker-MacBook-Pro:tmp abaker$ >> >> I do see that the jenkins build is including up some extra dirs (caches, >> daemon, ...) in the source distribution that don’t exist in a clean working >> directory. >> >> Anthony >> >> >> [1] >> https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/gemfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz >> >> >>> On Jan 4, 2016, at 1:45 PM, Bruce Schuchardt <bschucha...@pivotal.io> >> wrote: >>> >>> The gemfire-jgroups project has been deleted on the develop branch. That >> happened when feature/GEODE-77 was merged to develop. If it's still >> sitting around in a checkout it should be deleted. >>> >>> Le 1/4/2016 1:00 PM, Nitin Lamba a écrit : >>>> I didn't build locally but picked the artifacts that are getting posted >> from CI: >>>> >>>> >> https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/gemfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz >>>> >>>> All the java files I checked still had Pivotal copyright. Also, >> gemfire-jgroups/src/main/java directory is non-empty and has LGPL headers. >> Perhaps, Jenkins scripts need to be fixed. >>>> >>>> - Nitin >>>> >>>> ________________________________________ >>>> From: Anthony Baker <aba...@pivotal.io> >>>> Sent: Monday, January 4, 2016 11:41 AM >>>> To: dev@geode.incubator.apache.org >>>> Subject: Re: Source distribution >>>> >>>> Hmmm, that sounds odd. The srcDistTar task uses the current working >> copy. You might try a `git clean -fd` to remove all non-version controlled >> artifacts (be careful!). >>>> >>>> Which copyrights are missing? Here’s what I see in the src >> distribution: >>>> >>>> Anthony-Baker-MacBook-Pro:distributions abaker$ head >> apache-geode-src-1.0.0-incubating-SNAPSHOT/build.gradle >>>> /* >>>> * Licensed to the Apache Software Foundation (ASF) under one or more >>>> * contributor license agreements. See the NOTICE file distributed with >>>> * this work for additional information regarding copyright ownership. >>>> * The ASF licenses this file to You under the Apache License, Version >> 2.0 >>>> * (the "License"); you may not use this file except in compliance with >>>> * the License. You may obtain a copy of the License at >>>> * >>>> * http://www.apache.org/licenses/LICENSE-2.0 >>>> * >>>> >>>> The LGPL jgroups source dependency has been removed. We still have a >> binary dependency on an ASLv2 licensed version of jgroups for reliable >> mcast communication. >>>> >>>> Anthony >>>> >>>> >>>>> On Jan 4, 2016, at 11:21 AM, Nitin Lamba <ni...@ampool.io> wrote: >>>>> >>>>> Thanks Anthony!! This is great progress as the community marches >> towards the first GEODE release! >>>>> >>>>> Besides the missing LICENSE and NOTICE files (you have a separate >> thread on GEODE-610), I noticed a few things in the src artifact: >>>>> - The copyright updates are missing >>>>> - It still has jgroups/ LGPL files >>>>> >>>>> Do you know if the srcDistTar getting generated from 'master'? Once >> the release is cut, it'll probably pick-up the latest changes from develop >> so maybe this is intentional. I'll check the gradle file on my end too. >>>>> >>>>> -Nitin >>>>> PS: I've updated the release wiki page with the latest status: >>>>> >> https://cwiki.apache.org/confluence/display/GEODE/1.0.0-alpha1+%28First%29+Release >>>>> >>>>> ________________________________________ >>>>> From: Anthony Baker <aba...@pivotal.io> >>>>> Sent: Thursday, December 31, 2015 5:08 AM >>>>> To: dev@geode.incubator.apache.org >>>>> Subject: Source distribution >>>>> >>>>> I added a build command for creating a source distribution (see >> GEODE-627): >>>>> >>>>> `gradle srcDistTar` >>>>> >>>>> A normal build will create both the binary and src tar/zip files. >>>>> >>>>> Anthony-Baker-MacBook-Pro:incubator-geode abaker$ ls -l >> gemfire-assembly/build/distributions/ >>>>> total 404040 >>>>> -rw-r--r-- 1 abaker staff 89908576 Dec 31 06:53 >> apache-geode-1.0.0-incubating-SNAPSHOT.tar.gz >>>>> -rw-r--r-- 1 abaker staff 89923450 Dec 31 06:53 >> apache-geode-1.0.0-incubating-SNAPSHOT.zip >>>>> -rw-r--r-- 1 abaker staff 10381760 Dec 31 06:59 >> apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz >>>>> -rw-r--r-- 1 abaker staff 16648398 Dec 31 06:57 >> apache-geode-src-1.0.0-incubating-SNAPSHOT.zip >>>>> >>>>> >>>>> Anthony >>>>> >>> >> >>
signature.asc
Description: Message signed with OpenPGP using GPGMail
