----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42466/#review115029 -----------------------------------------------------------
I didn't see the new unit tests in the change set - Darrel Schneider On Jan. 18, 2016, 9:03 a.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42466/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9:03 a.m.) > > > Review request for geode and anilkumar gingade. > > > Repository: geode > > > Description > ------- > > There was a lot of overly-complicated code in FilterProfile to implement its > own copy-on-write but we now have CopyOnWriteHashSet and CopyOnWriteHashMap. > This change-set converts FilterProfile to use those classes. > > This change-set also includes refactoring of unregisterClientInterest > performed in a group refactoring session last week. It adds unit tests for > unregisterClientInterest that give 96% code coverage for that algorithm and > substantially increased coverage for registerClientInterest as well. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java > 7e41f68e4e30b139bb061c9402bb31327172a41d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 2bc2f05b837128a5c35d62017e412e72ac39ccfe > > Diff: https://reviews.apache.org/r/42466/diff/ > > > Testing > ------- > > precheckin including new tests > > > Thanks, > > Bruce Schuchardt > >
