----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42466/#review115044 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/FilterProfileJUnitTest.java (line 44) <https://reviews.apache.org/r/42466/#comment175891> Should this test still be classified as an "integration" test? It looks like testFilterProfile does not use the mocks you added to setUp so I think it is still an integration test. But your new tests all use mocks so we can run them as unit tests. I'm not sure the best way to do it but it seems like the old integration test could be moved to a new test with a different name. FilterProfileJUnitTest could be used for just the new unit tests and remove the integration category from it. - Darrel Schneider On Jan. 18, 2016, 10:18 a.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42466/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 10:18 a.m.) > > > Review request for geode and anilkumar gingade. > > > Repository: geode > > > Description > ------- > > There was a lot of overly-complicated code in FilterProfile to implement its > own copy-on-write but we now have CopyOnWriteHashSet and CopyOnWriteHashMap. > This change-set converts FilterProfile to use those classes. > > This change-set also includes refactoring of unregisterClientInterest > performed in a group refactoring session last week. It adds unit tests for > unregisterClientInterest that give 96% code coverage for that algorithm and > substantially increased coverage for registerClientInterest as well. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java > 7e41f68e4e30b139bb061c9402bb31327172a41d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 2bc2f05b837128a5c35d62017e412e72ac39ccfe > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/FilterProfileJUnitTest.java > 66bb0bc9844d67a99734ad1471e2f960f49f8799 > > gemfire-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt > d3a141abc0d25abd7653ef95abe6570e188e6649 > > Diff: https://reviews.apache.org/r/42466/diff/ > > > Testing > ------- > > precheckin including new tests > > > Thanks, > > Bruce Schuchardt > >
