----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45336/#review125450 -----------------------------------------------------------
Fix it, then Ship it! Ship It! geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java (line 2184) <https://reviews.apache.org/r/45336/#comment188234> This is under debug logic...You may need to log it as log.debug()... And change message to reflect the action "Processing FilterInfo"... You don't want to reurn from here...This needs to fall through to get other part of the code to get executed, Similar to error handlling in this logic... geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java (line 3717) <https://reviews.apache.org/r/45336/#comment188233> Can we change the log message to reflect the action...Similar to following messge in this method: logger.info("Found null client proxy. Failed to register Filters during HARegion GII. Region :{}", region.getName()); geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java (line 534) <https://reviews.apache.org/r/45336/#comment188236> This comment confuses...Can we change this to. //Fix for GEM-525, CacheClientNotifier is created for subscription cache servers, not for Gateway Reciever. geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java (line 181) <https://reviews.apache.org/r/45336/#comment188237> How about checking for CCN here; it should not have created.... - anilkumar gingade On March 25, 2016, 5:59 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45336/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 5:59 p.m.) > > > Review request for geode, anilkumar gingade and Dan Smith. > > > Bugs: GEM-454, GEM-525 and GEODE-920 > https://issues.apache.org/jira/browse/GEM-454 > https://issues.apache.org/jira/browse/GEM-525 > https://issues.apache.org/jira/browse/GEODE-920 > > > Repository: geode > > > Description > ------- > > It's both GEODE-920, GEM-454, GEM-525. > > If gateway receiver is created before cache server, the notify subscriptions > attributes can never been set, since CCN singleton is created by the gateway > receiver. > > The easy fix is not to let gateway receiver create the CCN singleton. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java > 34e3855 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java > 8803c32 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java > 9f18f50 > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45336/diff/ > > > Testing > ------- > > - introduced new dunit test. > - precheckin > - regression tests: > > > Thanks, > > xiaojian zhou > >
