----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45336/#review125466 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java (line 534) <https://reviews.apache.org/r/45336/#comment188261> Don't put pivotal bug numbers into apache code. geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java (line 170) <https://reviews.apache.org/r/45336/#comment188260> Another pivotal bug number. - Dan Smith On March 25, 2016, 5:59 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45336/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 5:59 p.m.) > > > Review request for geode, anilkumar gingade and Dan Smith. > > > Bugs: GEM-454, GEM-525 and GEODE-920 > https://issues.apache.org/jira/browse/GEM-454 > https://issues.apache.org/jira/browse/GEM-525 > https://issues.apache.org/jira/browse/GEODE-920 > > > Repository: geode > > > Description > ------- > > It's both GEODE-920, GEM-454, GEM-525. > > If gateway receiver is created before cache server, the notify subscriptions > attributes can never been set, since CCN singleton is created by the gateway > receiver. > > The easy fix is not to let gateway receiver create the CCN singleton. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java > 34e3855 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java > 8803c32 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java > 9f18f50 > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45336/diff/ > > > Testing > ------- > > - introduced new dunit test. > - precheckin > - regression tests: > > > Thanks, > > xiaojian zhou > >
