----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45509/ -----------------------------------------------------------
(Updated April 5, 2016, 9:28 p.m.) Review request for geode, John Blum and Mark Bretl. Changes ------- After discussion, we decided it would be better not to bundle spring data gemfire at all. The new diff removes the bundled version of SDG and the special handling to add SDG and related jars to the classpath when --spring-xml-location is specified. the user will instead need to manually add SDG to the classpath. I also pulled spring-aop, spring-context-support, and spring-webmvc out of the compile classpath for geode-core so that we will no longer ship these jars in the lib directory. Repository: geode Description ------- Spring Data Gemfire (SDG) now implements the service provider required to start the cache server with spring. Switching to point at the latest SDG snapshot and renabling the test for starting with SDG. Diffs (updated) ----- build.gradle 85e5c3564e0a347f4442d064f800f45822d53302 geode-assembly/build.gradle 5930f13c5307e0cd70396b019263176a377d415a geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java afb2770487c5ea7d53b79946b18ac2c40ec8830d geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java d7e7970aa2e989069cf7752f452237dd3feb3e4b geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION geode-core/build.gradle 041dc07c860c008f117d37969ee688375c2a348d geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java f540e19645bd65c7a44d492d2f073d95c389adc1 geode-rebalancer/build.gradle PRE-CREATION geode-web/build.gradle 596590b1c96e016e2dd927a21dc50d2e373b62b2 gradle/dependency-versions.properties 901bdd5631af0a30ec7ea5f2ce296c6db4152d5d Diff: https://reviews.apache.org/r/45509/diff/ Testing ------- Thanks, Dan Smith
