----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45509/#review127225 -----------------------------------------------------------
geode-assembly/src/test/resources/expected_jars.txt <https://reviews.apache.org/r/45509/#comment190399> This might actually be required by the Developer and Management REST APIs, an in particular the Management REST API on a Manager when the server serves as a Manager. Maybe this exclusion/removal does not matter. Not even sure what this file is, but appears to be used to validate required JARs for testing purposes. geode-assembly/src/test/resources/expected_jars.txt (line 66) <https://reviews.apache.org/r/45509/#comment190400> Not sure why Spring HATEOAS is here. I don't think we use it at all and was purely for experimental purposes when developing the Developer REST API, FYI. geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java <https://reviews.apache.org/r/45509/#comment190401> So remind me again... we are requiring the user to explicility specify all (required) Spring JARS on the classpath (using the --classpath option) when using the --spring-xml-location option on 'start server'? I guess this is consistent with the user having to explicility include the SDG JAR on the CP when starting a GemFire Server configured with Spring using Gfsh. gradle/dependency-versions.properties (line 88) <https://reviews.apache.org/r/45509/#comment190402> Again, I don't think this is needed either. - John Blum On April 5, 2016, 9:32 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45509/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 9:32 p.m.) > > > Review request for geode, John Blum and Mark Bretl. > > > Repository: geode > > > Description > ------- > > Spring Data Gemfire (SDG) now implements the service provider required > to start the cache server with spring. Switching to point at the latest > SDG snapshot and renabling the test for starting with SDG. > > > Diffs > ----- > > build.gradle 85e5c3564e0a347f4442d064f800f45822d53302 > geode-assembly/build.gradle 5930f13c5307e0cd70396b019263176a377d415a > > geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > afb2770487c5ea7d53b79946b18ac2c40ec8830d > > geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java > d7e7970aa2e989069cf7752f452237dd3feb3e4b > geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION > geode-core/build.gradle 041dc07c860c008f117d37969ee688375c2a348d > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java > f540e19645bd65c7a44d492d2f073d95c389adc1 > geode-rebalancer/build.gradle PRE-CREATION > geode-web/build.gradle 596590b1c96e016e2dd927a21dc50d2e373b62b2 > gradle/dependency-versions.properties > 901bdd5631af0a30ec7ea5f2ce296c6db4152d5d > > Diff: https://reviews.apache.org/r/45509/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
