Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/201#discussion_r71578385
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java
---
@@ -979,15 +1009,14 @@ private void initializeRegion(AbstractGatewaySender
sender,
SerialGatewaySenderQueueMetaRegion meta = new
SerialGatewaySenderQueueMetaRegion(
this.regionName, ra, null, gemCache, sender);
try {
- this.region = gemCache.createVMRegion(
- this.regionName,
- ra,
- new InternalRegionArguments().setInternalMetaRegion(meta)
- .setDestroyLockFlag(true).setSnapshotInputStream(null)
- .setImageTarget(null)
- .setIsUsedForSerialGatewaySenderQueue(true)
- .setSerialGatewaySender(sender));
-
+ this.region = gemCache.createVMRegion(this.regionName, ra, new
InternalRegionArguments().setInternalMetaRegion(meta)
+
.setDestroyLockFlag(true)
+
.setSnapshotInputStream(null)
+
.setImageTarget(null)
+
.setIsUsedForSerialGatewaySenderQueue(true)
+
.setInternalRegion(true)
--- End diff --
I would be nice if this diff just showed one line (the addition of
".setInternalRegion(true)". Are you not using the checked in geode code style?
I actually like your new indentation better but it seems like we should all use
a consistent formatter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
