Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/201#discussion_r71579111
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java ---
@@ -424,14 +429,26 @@ private void initializeRedis() {
RegionFactory<ByteArrayWrapper, ByteArrayWrapper> rfString =
cache.createRegionFactory(DEFAULT_REGION_TYPE);
RegionFactory<ByteArrayWrapper, HyperLogLogPlus> rfHLL =
cache.createRegionFactory(DEFAULT_REGION_TYPE);
Region<ByteArrayWrapper, ByteArrayWrapper> stringsRegion;
- if ((stringsRegion = this.cache.getRegion(STRING_REGION)) == null)
- stringsRegion = rfString.create(GeodeRedisServer.STRING_REGION);
+ InternalRegionArguments ira = new
InternalRegionArguments().setInternalRegion(true);
+ AttributesFactory af = new AttributesFactory();
+ af.setScope(Scope.LOCAL);
+ RegionAttributes ra = af.create();
Region<ByteArrayWrapper, HyperLogLogPlus> hLLRegion;
- if ((hLLRegion = this.cache.getRegion(HLL_REGION)) == null)
- hLLRegion = rfHLL.create(HLL_REGION);
Region<String, RedisDataType> redisMetaData;
- if ((redisMetaData = this.cache.getRegion(REDIS_META_DATA_REGION))
== null)
- redisMetaData = rfMeta.create(REDIS_META_DATA_REGION);
+ try {
+ if ((stringsRegion = this.cache.getRegion(STRING_REGION)) == null)
+ stringsRegion = rfString.create(GeodeRedisServer.STRING_REGION,
ra, ira);
+ if ((hLLRegion = this.cache.getRegion(HLL_REGION)) == null)
+ hLLRegion = rfHLL.create(HLL_REGION, ra, ira);
+ if ((redisMetaData = this.cache.getRegion(REDIS_META_DATA_REGION))
== null)
+ redisMetaData = rfMeta.create(REDIS_META_DATA_REGION, ra, ira);
+ }
+ catch (IOException | ClassNotFoundException e) {
--- End diff --
The addition of this try/catch does not look related to region names. Seems
like it should have its own ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
