----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/#review145629 -----------------------------------------------------------
Looks good! I had a couple of comments about the LocatorServerConfigurationRule, see below. geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java (line 49) <https://reviews.apache.org/r/51010/#comment211933> This could probably extend ExternalResource rather than directly implementing TestRule. geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java (line 99) <https://reviews.apache.org/r/51010/#comment211939> I'm not sure getLocatorVM is the right thing to call this. It's not really getting the locator, it's actually configuring the locator. I suspect many tests you might not actually need to get the locator VM. Could the Rule just set this stuff up before the test runs, I wonder? geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java (line 113) <https://reviews.apache.org/r/51010/#comment211935> What if someone calls getVM instead of getNodeVM? I wonder if it would be possible to make this work so that someone doesn't need to call getNodeVM? geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java (line 122) <https://reviews.apache.org/r/51010/#comment211938> Use port 0 instead to avoid potential races. You can get the port back from the locator after it starts. See DUnitLauncher.startLocator. geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java (line 129) <https://reviews.apache.org/r/51010/#comment211936> This could be a lambda: locator.invoke(() -> {...}) - Dan Smith On Aug. 11, 2016, 10:34 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51010/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 10:34 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Kirk > Lund, William Markito, nabarun nag, Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Added test to validate Cluster configuration support for Lucene indexes. > > Added a new Rule to create Distributed System with test/custom > configuration...The "LocatorServerConfigurationRule" makes it easier to > create a Locator or cluster nodes with required configuration. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/51010/diff/ > > > Testing > ------- > > Run the newly added test. > > > Thanks, > > anilkumar gingade > >
