> On Sept. 13, 2016, 4:16 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java, > > line 773 > > <https://reviews.apache.org/r/51831/diff/1/?file=1497503#file1497503line773> > > > > Not sure if this could save a lot interms of temp GC: > > > > if (this.isOffHeapPossigle()) { > > return OffHeapHelper.copyIfNeeded(basicGetNewValue()); > > } > > return basicGetNewValue();
My understanding is that local variables are not a gc issue - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51831/#review148800 ----------------------------------------------------------- On Sept. 12, 2016, 5:50 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51831/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 5:50 p.m.) > > > Review request for geode, anilkumar gingade and Eric Shu. > > > Bugs: GEODE-1886 > https://issues.apache.org/jira/browse/GEODE-1886 > > > Repository: geode > > > Description > ------- > > The EntryEventImpl code now checks the region first to see if it is > configured off-heap. > If it is not it can give up early and not bother checking if it is an > instance of StoredObject. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java > bd7596f84a6a80e420c52e3a60df9e36e9a70ebb > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java > bc8a64e8aebb497ec71290c645363a2aeb678e29 > > Diff: https://reviews.apache.org/r/51831/diff/ > > > Testing > ------- > > precheckin, perf test > > > Thanks, > > Darrel Schneider > >
